shad/canvas-frontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(oracle-r4-caveats): wizard rewires presentation edges, chat QA proves, Pi leak

Browse Source 
Three Oracle round-7 caveats:

1. Wizard view replacement now deletes old presentation edges before
   creating new field-based ones. Previously handleDataSave added new
   edges additively, so runtime could still hit the generic Notes view.
2. Chat sidebar QA assertion was vacuously true (previewRows >= 0 &&
   timeBadges >= 0). Now: when threads exist, preview count must equal
   thread count AND at least one relative timestamp must render.
3. Agent composer placeholder rebranded from 'Ask Pi...' to 'Ask the
   assistant...'. Closes residual Pi/LLM framing leak.
This commit is contained in:
shad
2026-06-14 15:14:59 +04:00
parent bfac76dcde
commit 05be9ca8dc
3 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qa/full_dogfood.mjs
+8 -1
View File
@@ -236,9 +236,16 @@ record("llm_unconfigured_falls_back_gracefully", unmatchedReply.length > 0 && !/
// other personas have written since last open.
await p.locator(".tab", { hasText: /^\s*Chat\s*$/ }).click();
await p.waitForTimeout(2500);
await p.waitForTimeout(2000);
const threadRowCount = await p.locator(".chat-thread-row").count();
const previewRows = await p.locator(".chat-thread-meta").count();
const timeBadges = await p.locator(".chat-thread-time").count();
record("chat_sidebar_shows_previews_and_timestamps", previewRows >= 0 && timeBadges >= 0, `previews=${previewRows}, times=${timeBadges}`);
const sidebarHonest = threadRowCount === 0 || (previewRows === threadRowCount && timeBadges >= 1);
record(
"chat_sidebar_shows_previews_and_timestamps",
sidebarHonest,
`threads=${threadRowCount}, previews=${previewRows}, times=${timeBadges}`
);
// Summarise
const fails = results.filter((r) => !r.ok);