shad/canvas-frontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(curation): explicit STARTABLE_FLOW_KEYS allowlist

Browse Source 
Previous attempt blacklisted unstartable backfill source_contexts but
swept all real published flows out too. Inverted to a positive
allowlist: only flows whose _key is in STARTABLE_FLOW_KEYS reach the
Hubs / Assistant.

Today the canonical pr_to_po_def is the only runtime-startable flow in
the tenant. New entries are added by hand once we've verified a flow
actually starts via /api/runtime/transactions. Cleaner than chasing
source_context strings.
This commit is contained in:
shad
2026-06-14 14:23:19 +04:00
parent 11e8442a93
commit e70944b6fa
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qa/full_dogfood.mjs
+2 -3
View File
@@ -191,9 +191,8 @@ for (const name of flowNames) {
} }
record("assistant_list_processes_all_startable", unstartable.length === 0, unstartable.length ? `unstartable: ${unstartable.join(", ")}` : `${flowNames.length} flows all startable`); record("assistant_list_processes_all_startable", unstartable.length === 0, unstartable.length ? `unstartable: ${unstartable.join(", ")}` : `${flowNames.length} flows all startable`);
// 14. NEGATIVE: agent welcome must not claim to be an "AI agent". // 14. NEGATIVE: agent welcome must not claim to be an "AI agent". The Assistant
await p.locator(".hub-chip", { hasText: /Command Assistant/i }).click(); // scene is already open from step 13, so read the first turn body directly.
await p.waitForTimeout(800);
const welcome = (await p.locator(".agent-turn-agent .agent-turn-body").first().textContent()) || ""; const welcome = (await p.locator(".agent-turn-agent .agent-turn-body").first().textContent()) || "";
const honestyOk = !/\bai agent\b/i.test(welcome) || /command assistant/i.test(welcome); const honestyOk = !/\bai agent\b/i.test(welcome) || /command assistant/i.test(welcome);
record("agent_welcome_does_not_overclaim_ai", honestyOk, welcome.slice(0, 80)); record("agent_welcome_does_not_overclaim_ai", honestyOk, welcome.slice(0, 80));
src/lib/flowCuration.ts
+10 -6
View File
@@ -40,11 +40,10 @@ const NON_BUSINESS_SOURCE_CONTEXTS = new Set([
"CANVAS_SEED_STEP", "CANVAS_SEED_STEP",
"EA2_WIZARD_STEP", "EA2_WIZARD_STEP",
"EA2_DRAFT_PROCESS:process_creation", "EA2_DRAFT_PROCESS:process_creation",
"D2 live backfill 2026-04-25; derived from seed fields, existing description/content, and graph name.", ]);
"EA2 runtime reference seed",
"atlas-f1-fresh-proof", const STARTABLE_FLOW_KEYS = new Set<string>([
"EA2 seed payload via POST /api/process", "pr_to_po_def",
"fm-process-mining-conformance-reseed",
]); ]);
const HEX32 = /[a-f0-9]{32}/gi; const HEX32 = /[a-f0-9]{32}/gi;
@@ -58,7 +57,12 @@ export function isDevArtefact(f: RawFlow): boolean {
export function curatedPublishedFlows<T extends RawFlow>(items: T[]): T[] { export function curatedPublishedFlows<T extends RawFlow>(items: T[]): T[] {
return items.filter( return items.filter(
(it) => it.status === "published" && it.kind === "definition" && !!it.display_name && !isDevArtefact(it) (it) =>
it.status === "published" &&
it.kind === "definition" &&
!!it.display_name &&
!isDevArtefact(it) &&
STARTABLE_FLOW_KEYS.has(it._key)
); );
} }