Shad e3b4ed62c0
Some checks failed
build-and-publish / test (push) Has been cancelled
build-and-publish / image (push) Has been cancelled
fix(oracle-r2): same-origin baseUrl + refresh actually re-fetches
Oracle round-2 review caught two real bugs:

1. Production baseUrl bypassed the nginx /api proxy
   - api.ts defaulted to https://demo.flow-master.ai in prod
   - Browser would hit cross-origin and CORS-fail
   - Now: baseUrl='' everywhere; nginx.conf already reverse-proxies /api/*
   - vite.config.ts proxy still handles dev

2. Refresh button didn't refresh
   - setMode('live') early-returned when already in live mode
   - Now: setMode() and refreshLive() share runLiveFetch(); refreshLive
     ignores the same-mode guard and always re-runs
   - 4 new vitest regressions in state/store.test.ts cover the contract
   - Smoke now asserts /api/ea2/work-items is called twice after Refresh

Also:
- buildScenarios.ts parallelized: cap N=6 candidates, Promise.all per-
  candidate fetches → live mode now ~3s instead of 30s
- CommandBar + LeftRail preview toasts now name the exact endpoint
  (/api/runtime/transactions/{id}/actions) in the visible text
- Landing 'Go live' button rebound to refreshLive() when already live;
  copy changed to 'Live · refresh'
- README: scenario table now renders (added separator row); deploy
  section points at the real ops PR + the actual overlay path
  (overlays/demo, not overlays/mc.flow-master.ai); CORS doc clarifies
  same-origin requirement

Constraint: browsers reject cross-origin → same-origin /api/* required
Rejected: dev/prod baseUrl divergence | created production bug
Confidence: high
Scope-risk: narrow
Not-tested: production image actually built + served by ops PR (gated by trusted updater + DNS)
2026-06-14 00:26:38 +04:00

190 lines
8.9 KiB
JavaScript

// Playwright smoke + screenshot capture against the running dev server.
// Covers: landing, MC procurement, MC blueprint (AR), inspector tabs,
// command palette, tour, run history, live-mode toggle, toast on preview action.
import { chromium } from "playwright";
import { mkdirSync } from "node:fs";
const URL = process.env.URL || "http://127.0.0.1:5173";
const OUT = "qa/screenshots";
mkdirSync(OUT, { recursive: true });
const VP = { width: 1440, height: 900 };
function logOk(label, ok, detail = "") {
console.log(`${ok ? "✓" : "✗"} ${label}${detail ? " · " + detail : ""}`);
if (!ok) process.exitCode = 1;
}
const browser = await chromium.launch({ headless: true });
const ctx = await browser.newContext({ viewport: VP, deviceScaleFactor: 1 });
const page = await ctx.newPage();
const errors = [];
page.on("pageerror", (e) => errors.push(`pageerror: ${e.message}`));
page.on("console", (m) => { if (m.type() === "error") errors.push(`console.error: ${m.text()}`); });
await page.goto(URL, { waitUntil: "networkidle" });
await page.waitForTimeout(400);
await page.screenshot({ path: `${OUT}/01-landing.png` });
logOk("landing renders", await page.locator(".landing").isVisible());
logOk("hero title present", await page.locator(".hero-title").isVisible());
const cards = await page.locator(".sc-card").count();
logOk("scenario cards >= 7", cards >= 7, `count=${cards}`);
logOk("Go live button visible on landing", await page.getByRole("button", { name: /go live/i }).isVisible());
// → Mission Control via first card (live procurement)
await page.locator(".sc-card").first().click();
await page.waitForSelector(".mc");
await page.waitForTimeout(600);
await page.screenshot({ path: `${OUT}/02-mission-procurement.png` });
logOk("mission control loaded", await page.locator(".mc-strip").isVisible());
// Topbar mode pill is SNAPSHOT by default
const modeBefore = (await page.locator(".mode-toggle .mode-pill").innerText()).trim();
logOk("default mode is SNAPSHOT", modeBefore === "SNAPSHOT", `was=${modeBefore}`);
// Tab strip + graph
const tabCount = await page.locator(".mc-tab").count();
logOk("tab strip has >= 7 scenarios", tabCount >= 7, `count=${tabCount}`);
const reactFlowNodes = await page.locator(".node").count();
logOk("graph rendered nodes > 0", reactFlowNodes > 0, `nodes=${reactFlowNodes}`);
// Switch to AR blueprint
await page.locator(".mc-tab", { hasText: "Accounts Receivable" }).click();
await page.waitForTimeout(600);
await page.screenshot({ path: `${OUT}/03-mission-ar.png` });
logOk("AR scenario active", (await page.locator(".mc-hero-title").innerText()).toLowerCase().includes("refund"));
logOk("AR shows BLUEPRINT badge (not SYNTHETIC)", await page.locator(".graph-overlay .tag-syn", { hasText: "BLUEPRINT" }).isVisible());
// Queue card → inspector update
const qCards = await page.locator(".qcard").count();
logOk("queue cards present", qCards > 0, `count=${qCards}`);
if (qCards > 0) {
await page.locator(".qcard").first().click();
await page.waitForTimeout(200);
}
// Inspector tab switching
await page.locator(".itab", { hasText: "Evidence" }).click();
await page.waitForTimeout(150);
logOk("evidence tab opens", await page.locator(".evt, .empty").first().isVisible());
await page.locator(".itab", { hasText: "Raw" }).click();
await page.waitForTimeout(150);
logOk("raw tab opens", await page.locator(".raw-json").isVisible());
await page.screenshot({ path: `${OUT}/04-inspector-raw.png` });
// Preview-only action toast
await page.locator(".itab", { hasText: "Overview" }).click();
await page.waitForTimeout(150);
const approveBtn = page.locator(".i-actions .btn", { hasText: "Approve" }).first();
const approveCount = await approveBtn.count();
if (approveCount > 0) {
await approveBtn.click();
await page.waitForTimeout(300);
const toastTxt = (await page.locator(".toast-msg").first().innerText()).trim();
logOk("preview action fires toast", /preview[- ]only/i.test(toastTxt), `toast="${toastTxt.slice(0, 80)}"`);
} else {
logOk("approve button preview-marker present", await page.locator(".preview-marker").first().isVisible());
}
// Command palette
await page.keyboard.press("Meta+k");
await page.waitForSelector(".cmd", { state: "visible" });
await page.waitForTimeout(150);
await page.screenshot({ path: `${OUT}/05-command-palette.png` });
logOk("command palette opens with ⌘K", await page.locator(".cmd").isVisible());
logOk("Data mode group present in palette", await page.locator(".cmd").getByText(/data mode/i).isVisible());
await page.locator('.cmd [cmdk-input]').fill("tour");
await page.waitForTimeout(150);
logOk("tour command appears", await page.locator(".cmd").getByText(/start guided tour/i).isVisible());
await page.keyboard.press("Escape");
await page.waitForTimeout(100);
// Start tour
await page.locator(".link-btn", { hasText: "Tour" }).click();
await page.waitForSelector(".tour-card");
await page.waitForTimeout(250);
await page.screenshot({ path: `${OUT}/06-tour.png` });
logOk("tour card renders", await page.locator(".tour-card").isVisible());
const firstTourCombined = ((await page.locator(".tour-title").first().innerText()) + " " + (await page.locator(".tour-body").first().innerText())).toLowerCase();
logOk("AR tour uses positive 'industry blueprint' framing", /industry blueprint/i.test(firstTourCombined), `text~="${firstTourCombined.slice(0, 100)}"`);
await page.keyboard.press("ArrowRight");
await page.waitForTimeout(450);
logOk("tour advances", (await page.locator(".tour-title").first().innerText()).length > 0);
await page.keyboard.press("Escape");
// Live-mode toggle (real network call to demo.flow-master.ai via vite proxy)
const networkCalls = [];
page.on("request", (req) => {
if (req.url().includes("/api/ea2/work-items")) networkCalls.push(req.url());
});
const toggleBtn = page.locator(".mode-toggle").first();
await toggleBtn.click();
const liveOk = await page.waitForFunction(
() => Array.from(document.querySelectorAll(".mode-pill")).some((el) => el.textContent?.trim() === "LIVE"),
{ timeout: 12000 },
).then(() => true).catch(() => false);
logOk("toggle to LIVE mode resolves and updates pill", liveOk);
if (liveOk) {
await page.waitForTimeout(400);
await page.screenshot({ path: `${OUT}/09-live-mode.png` });
logOk("Refresh button appears in live mode", await page.locator(".link-btn", { hasText: "Refresh" }).isVisible());
// Refresh must trigger ANOTHER /api/ea2/work-items request (Oracle round 2 fix).
// Wait for the Refresh button to become enabled (initial fetch may still be settling).
await page.locator(".link-btn", { hasText: "Refresh" }).waitFor({ state: "visible" });
await page.waitForFunction(
() => {
const btns = Array.from(document.querySelectorAll(".link-btn"));
const btn = btns.find((b) => (b.textContent || "").includes("Refresh"));
return btn && !btn.disabled;
},
{ timeout: 10000 },
);
const before = networkCalls.length;
await page.locator(".link-btn", { hasText: "Refresh" }).click();
await page.waitForTimeout(2500);
logOk("Refresh re-fetches /api/ea2/work-items", networkCalls.length > before,
`before=${before} after=${networkCalls.length}`);
}
// LeftRail Confirm button: toast must name /api/runtime/transactions/{id}/actions
await page.locator(".mc-tab", { hasText: "Accounts Receivable" }).click();
await page.waitForTimeout(400);
const confirmBtn = page.locator(".agent-acts .btn-primary").first();
if (await confirmBtn.count() > 0) {
await confirmBtn.click();
await page.waitForTimeout(300);
const lastToast = (await page.locator(".toast-msg").last().innerText()).trim();
logOk("LeftRail Confirm toast names /api/runtime/transactions endpoint",
/\/api\/runtime\/transactions\/\{id\}\/actions/.test(lastToast),
`toast="${lastToast.slice(0, 80)}"`);
}
// Telemetry honesty (check before leaving MC because RH has no telemetry strip)
const tel = await page.locator(".telemetry").innerText();
logOk("telemetry has no hardcoded 97.4%", !/97\.4%/.test(tel), `tel="${tel.replace(/\s+/g, " ").slice(0, 80)}"`);
logOk("telemetry labels SLA as derived", /derived/i.test(tel));
// Run history scene
await page.locator(".tab", { hasText: "Runs" }).click();
await page.waitForSelector(".rh");
await page.waitForTimeout(250);
await page.screenshot({ path: `${OUT}/07-run-history.png` });
const rhRows = await page.locator(".rh-row").count();
logOk("run-history rows present", rhRows > 0, `rows=${rhRows}`);
await page.locator(".rh-chip", { hasText: "running" }).click();
await page.waitForTimeout(200);
const rhRunning = await page.locator(".rh-row").count();
logOk("run-history filter shrinks list", rhRunning > 0 && rhRunning <= rhRows, `running=${rhRunning} of ${rhRows}`);
console.log(`\nconsole errors: ${errors.length}`);
for (const e of errors.slice(0, 8)) console.log(" -", e);
if (errors.length > 0) process.exitCode = 1;
await browser.close();
const fs = await import("node:fs/promises");
const list = await fs.readdir(OUT);
console.log(`\n${OUT}/ has ${list.length} screenshots: ${list.sort().join(", ")}`);